-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove qiskit-bot notification rule for rust changes #13198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and `@kevinhartman` as the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry.
One or more of the following people are relevant to this code:
|
jakelishman
approved these changes
Sep 20, 2024
jakelishman
added
type: qa
Issues and PRs that relate to testing and code quality
stable backport potential
The bug might be minimal and/or import enough to be port to stable
labels
Sep 20, 2024
Pull Request Test Coverage Report for Build 10958345301Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and `@kevinhartman` as the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry. (cherry picked from commit 597f2b2)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and `@kevinhartman` as the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry. (cherry picked from commit 597f2b2) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: None
Do not include in changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
type: qa
Issues and PRs that relate to testing and code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and
@kevinhartman
as the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry.Details and comments