Remove duplicated weyl_coordinates python function #13193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the weyl_coordinates() function from the private qiskit.synthesis.two_qubit.weyl module. This function's internal use was ported to rust as part of Qiskit#11019 but it left the python implementation intact while we ensured the rust implementation was reliable longer term. Since then we've ported the majority of the two qubit synthesis to rust now and the only usage of this python implementation was the unit tests. This commit removes the python implementation and the entire internal weyl module as nothing uses it anymore. A python interface is added to the rust function and the tests are updated to call that instead. Fixes: Qiskit#8459
mtreinish
added
Changelog: None
mtreinish
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10947950215Details
💛 - Coveralls |
jakelishman
reviewed
Sep 19, 2024
Comment on lines
+219
to
+234
| /// Computes the Weyl coordinates for a given two-qubit unitary matrix. | ||
| /// | ||
| /// Args: | ||
| /// U (np.ndarray): Input two-qubit unitary. | ||
| /// | ||
| /// Returns: | ||
| /// np.ndarray: Array of the 3 Weyl coordinates. | ||
| #[pyfunction] | ||
| fn weyl_coordinates(py: Python, unitary: PyReadonlyArray2<Complex64>) -> PyObject { | ||
| let array = unitary.as_array(); | ||
| __weyl_coordinates(array.into_faer_complex()) | ||
| .to_vec() | ||
| .into_pyarray_bound(py) | ||
| .into() | ||
| } | ||
|
|
There was a problem hiding this comment.
Did we consider this public interface in any way? If not: is there any chance it might get called with matrices whose dtypes are not complex? I'm asking because the Python code would have happily lifted the matrix to be complex early in the process (during the translation to the magic basis), but this will now just error immediately if anyone's doing things like weyl_coordinates(np.eye(2)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit removes the weyl_coordinates() function from the private qiskit.synthesis.two_qubit.weyl module. This function's internal use was ported to rust as part of #11019 but it left the python implementation intact while we ensured the rust implementation was reliable longer term. Since then we've ported the majority of the two qubit synthesis to rust now and the only usage of this python implementation was the unit tests. This commit removes the python implementation and the entire internal weyl module as nothing uses it anymore. A python interface is added to the rust function and the tests are updated to call that instead.
Details and comments
Fixes: #8459