-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation for utils.optionals data values (backport #13098) #13101
Conversation
(cherry picked from commit 254ba83) # Conflicts: # qiskit/utils/optionals.py
Cherry-pick of 254ba83 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10778463974Details
💛 - Coveralls |
@jakelishman it's not very important to land this in Qiskit 0.46. For example, we're not adding it to 1.0 and 1.1. The docs still render fine, only they don't have the little anchor icon & objects.inv's links don't take you to the right part of the page. Shall we close this given the non-trivial merge conflict? |
@Eric-Arellano FWIW, please check out #13111. I've opened it against #13101. If it's ok let's apply the changes there and have it included in 0.46.3. Note that #13111 also includes a few minor fixes relevant for 1.3. |
* Fix merge conflicts and a few minor issues * Reorder IPYTHON and another typo fix * Fix lint errors * Update qiskit/utils/optionals.py Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> * Update qiskit/utils/optionals.py Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We're adding proper support to
.. py:data::
to docs.quantum.ibm.com. However, we cannot easily handle.. py:data::
being inside a table - it would complicate both the code and visual design.So, this PR removes the table and uses
.. py:data::
like we use it everywhere else in Qiskit.This is an automatic backport of pull request #13098 done by [Mergify](https://mergify.com).