Fix Initialize.gates_to_uncompute method #12976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShellyGarion
added
the
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10465223853Details
💛 - Coveralls |
Cryoris
reviewed
Aug 19, 2024
|
The CI failures should be fixed after #12979 will be merged |
Cryoris
reviewed
Aug 19, 2024
There was a problem hiding this comment.
This is very related to the comment below: StatePreparation is a Gate but currently contains an Instruction (namely an Isometry). We should update this such that a gate contains only other gates, e.g. by doing something like
def _define_synthesis_isom(self):
# ... previous code ...
# we know Isometry produces only Gate objects in this case,
# so we can directly compose it's definition
isom = Isometry(self._params_arg, 0, 0)
initialize_circuit.compose(isom.definition, inplace=True, copy=False)
|
Let's wait for @woodsp-ibm to confirm this is good, but this LGTM -- thanks for the updates! 🙂 Edit: I just saw #12969 (comment), so it's good to go 👍🏻 |
Cryoris
approved these changes
Aug 20, 2024
Cryoris
added
the
stable backport potential
|
@Cryoris I had checked it yesterday and it was all good #12969 (comment) but I just rechecked it now and used both initializer and state_preparation files from here and it passes the finance tests so its all good. |
woodsp-ibm
approved these changes
Aug 20, 2024
|
Thanks for double checking @woodsp-ibm! (and thanks for remembering the merge queue @alexanderivrii 😉) |
mergify bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
* add back files needed in Initialize.gates_to_uncompute() * add a test for Initialize.gates_to_uncompute() method * fix a comment * add release notes * update gates_to_uncompute such that it will call Isometry * remove unused imports * transfer code from StatePreparation to Initialize.gates_to_uncompute * update code following review (cherry picked from commit aa09a02)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
* add back files needed in Initialize.gates_to_uncompute() * add a test for Initialize.gates_to_uncompute() method * fix a comment * add release notes * update gates_to_uncompute such that it will call Isometry * remove unused imports * transfer code from StatePreparation to Initialize.gates_to_uncompute * update code following review (cherry picked from commit aa09a02) Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #12969
Fix some code that has been removed in #12178, so that the
Initialize.gates_to_uncomputemethod will not failDetails and comments
Initialize.gates_to_uncomputeis based onStatePreparation._gates_to_uncompute()that now contains the inverse ofIsomteryin order to make it more efficient