Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StatevectorSampler to raise an error if a circuit with c_if is passed (backport #12842) #12851

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 30, 2024

Summary

StatevectorSampler cannot handle both control flow and c_if because Statevector cannot.
But, it ignores c_if by mistake. This PR makes StatevectorSampler raise an error if a circuit with c_if is passed.
A unit test of StatevectorSampler used c_if accidentally. So, this PR also fixes the case without passing c_if to StatevectorSampler.

Fixed #12281

Details and comments


This is an automatic backport of pull request #12842 done by [Mergify](https://mergify.com).

…passed (#12842)

* fix StatevectorSampler with c_if

* add comment

(cherry picked from commit 239a669)
@mergify mergify bot requested review from a team as code owners July 30, 2024 11:45
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @t-imamichi

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: primitives Related to the Primitives module labels Jul 30, 2024
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 30, 2024
@ElePT ElePT enabled auto-merge July 30, 2024 11:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10161716860

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.008%) to 89.972%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 93.13%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 10151658550: 0.008%
Covered Lines: 66350
Relevant Lines: 73745

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 30, 2024
@ElePT ElePT added this pull request to the merge queue Jul 30, 2024
Merged via the queue into stable/1.2 with commit e3cd5b3 Jul 30, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-12842 branch July 30, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: primitives Related to the Primitives module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants