Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitarray postselect (backport #12693) #12836

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Commits on Jul 29, 2024

  1. Bitarray postselect (#12693)

    * define BitArray.postselect()
    
    * add test for BitArray.postselect()
    
    * lint
    
    * remove redundant docstring text
    
    * Update qiskit/primitives/containers/bit_array.py
    
    Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
    
    * docstring ticks (BitArray.postselect())
    
    Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
    
    * Simpler tests for BitArray.postselect
    
    * lint
    
    * add release note
    
    * check postselect() arg lengths match
    
    * fix postselect tests
    
    - fix bugs with checking that ValueError is raised.
    - addtionally run all tests on a "flat" data input
    
    * lint
    
    * Fix type-hint
    
    We immediately check the lengths of these args, so they should be Sequences, not Iterables.
    
    * remove spurious print()
    
    * lint
    
    * lint
    
    * use bitwise operations for faster postselect
    
    - Also added support for negative indices
    - Also updated tests
    
    * remove spurious print()
    
    * end final line of release note
    
    * try to fix docstring formatting
    
    * fix bitarray test assertion
    
    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    
    * disallow postselect positional kwarg
    
    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    
    * fix numpy dtype args
    
    * Simpler kwarg: "assume_unique"
    
    * lint (line too long)
    
    * simplification: remove assume_unique kwarg
    
    * improve misleading comment
    
    * raise IndexError if indices out of range
    
    - Change ValueError to IndexError.
    - Add check for out-of-range negative indices.
    - Simplify use of mod
    - Update test conditions (include checks for off-by-one errors)
    
    * lint
    
    * add negative-contradiction test
    
    * Update docstring with IndexErrors
    
    * lint
    
    * change slice_bits error from ValueError to IndexError
    
    * update slice_bits test to use IndexError
    
    * change ValueError to IndexError in slice_shots
    
    also update tests for this error
    
    * update error type in slice_shots docstring
    
    * Revert ValueError to IndexError changes
    
    Reverting these changes as they will instead be made in a separate PR.
    
    This reverts commit 8f32178.
    
    Revert "update error type in slice_shots docstring"
    
    This reverts commit 50545ef.
    
    Revert "change ValueError to IndexError in slice_shots"
    
    This reverts commit c4becd9.
    
    Revert "update slice_bits test to use IndexError"
    
    This reverts commit c2b0039.
    
    * fix docstring formatting
    
    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    
    * allow selection to be int instead of bool
    
    * In tests, give selection as type int
    
    * lint
    
    * add example to release note
    
    * fix typo in test case
    
    * add check of test
    
    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    
    * lint
    
    ---------
    
    Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    (cherry picked from commit 0c03808)
    aeddins-ibm authored and mergify[bot] committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7fbe232 View commit details
    Browse the repository at this point in the history