Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting noise_info to false in GenericBackendV2 creates issues later in the transpiler pipeline (backport #12769) #12823

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 26, 2024

Summary

Fixes bugs introduced in #12747

Details and comments

I added some tests to check whether transpiling with noise-less and/or pulse-channel-less backends still works and noticed test failures. I fixed these bugs and added the corresponding test cases. I don't think this warrants a new release note but let me know if you disagree. :-)


This is an automatic backport of pull request #12769 done by [Mergify](https://mergify.com).

…in the transpiler pipeline (#12769)

* up

* fix

* Apply suggestions from code review

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* lint

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
(cherry picked from commit edf0b53)
@mergify mergify bot requested review from jyu00 and a team as code owners July 26, 2024 13:13
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: None Do not include in changelog mod: fake_provider Related to the fake_provider module and fake backends labels Jul 26, 2024
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10111872573

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.005%) to 89.953%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 4 92.62%
Totals Coverage Status
Change from base Build 10111125380: 0.005%
Covered Lines: 66098
Relevant Lines: 73481

💛 - Coveralls

@ElePT ElePT enabled auto-merge July 26, 2024 14:00
@ElePT ElePT added this pull request to the merge queue Jul 26, 2024
Merged via the queue into stable/1.2 with commit 706dfaa Jul 26, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-12769 branch July 26, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog mod: fake_provider Related to the fake_provider module and fake backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants