Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of the ProductFormula synthesizers #12724

Merged
merged 22 commits into from
Jul 8, 2024
Merged

Improve the performance of the ProductFormula synthesizers #12724

merged 22 commits into from
Jul 8, 2024

Commits on Jul 4, 2024

  1. [WIP] adds the output argument to the internal atomic evolution

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    dada3a6 View commit details
    Browse the repository at this point in the history

  2. meta: modernize type hints

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    bc00ecb View commit details
    Browse the repository at this point in the history

  3. refactor: change callable structure of atomic evolution 

    This changes the structure of the `atomic_evolution` callable in the
`ProductFormula` synthesis class. This is motivated by the significant
performance improvements that can be obtained by appending to the
existing circuit directly rather than building out individual evolution
circuits and iteratively composing them.
    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    849a768 View commit details
    Browse the repository at this point in the history

  4. refactor: deprecate the legacy atomic_evolution signature

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2137f1e View commit details
    Browse the repository at this point in the history

  5. refactor: add the wrap argument to ProductFormula 

    This can be used to recover the previous behavior in which the single
individually evolved Pauli terms get wrapped into gate objects.
    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    db601b7 View commit details
    Browse the repository at this point in the history

  6. fix: insert the missing barriers between LieTrotter repetitions

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    94b8eea View commit details
    Browse the repository at this point in the history

  7. refactor: align SuzukiTrotter and LieTrotter

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5d04a78 View commit details
    Browse the repository at this point in the history

  8. Propoagate deprecation notice

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e8c1f9e View commit details
    Browse the repository at this point in the history

  9. fix: the labels of wrapped Pauli evolutions

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    80b4fb7 View commit details
    Browse the repository at this point in the history

  10. fix: respect the insert_barriers setting

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f8a7c95 View commit details
    Browse the repository at this point in the history

  11. docs: add a release note

    @mrossinek
    mrossinek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e6e425e View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Julien Gacon <gaconju@gmail.com>
    @mrossinek @Cryoris
    mrossinek and Cryoris committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    84f5a5f View commit details
    Browse the repository at this point in the history

  2. fix: missing wrap forward in SuzukiTrotter

    @mrossinek
    mrossinek committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    bb825c7 View commit details
    Browse the repository at this point in the history

  3. docs: improve documentation of the atomic_evolution argument 

    Co-authored-by: Julien Gacon <gaconju@gmail.com>
    @mrossinek @Cryoris
    mrossinek and Cryoris committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    375170f View commit details
    Browse the repository at this point in the history

  4. docs: also document the deprecated form of atomic_evolution

    @mrossinek
    mrossinek committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    07de8c1 View commit details
    Browse the repository at this point in the history

  5. docs: call out ProductFormula docs in release note

    @mrossinek
    mrossinek committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    01cad96 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into local_atomic_evolution

    @mrossinek
    mrossinek committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4de223d View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'main' into local_atomic_evolution

    @mrossinek
    mrossinek committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ffa0a2b View commit details
    Browse the repository at this point in the history

  2. refactor: change to PendingDeprecationWarning

    @mrossinek
    mrossinek committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6f1cd7e View commit details
    Browse the repository at this point in the history

  3. refactor: explicitly convert to Gate when wrapping 

    This is slightly faster than the `.compose`-based operation done
previously as it performs fewer checks. Thanks to @jakelishman for the
suggestion offline.
    @mrossinek
    mrossinek committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5485bec View commit details
    Browse the repository at this point in the history

  4. Update qiskit/synthesis/evolution/lie_trotter.py 

    Co-authored-by: Julien Gacon <gaconju@gmail.com>
    @mrossinek @Cryoris
    mrossinek and Cryoris committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c128667 View commit details
    Browse the repository at this point in the history

  5. docs: update after pending deprecation

    @mrossinek
    mrossinek committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e261535 View commit details
    Browse the repository at this point in the history