Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v2 pulse drawer (backport #12608) #12613

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 20, 2024

Summary

v2 pulse drawer crashes when the draw function is called with a V2 backend that doesn't have configuration and defaults attributes. Since qiskit-ibm-runtime 0.24 was released and fake V1 backends were deprecated, we should to support visualization with fake V2 backends that doen't have configuration and defaults attributes.

Details and comments


This is an automatic backport of pull request #12608 done by [Mergify](https://mergify.com).

* fix error when V2 model is set

* Apply suggestions from code review

* Fix black

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
(cherry picked from commit 7d1731b)
@mergify mergify bot requested review from nonhermitian and a team as code owners June 20, 2024 13:43
@mergify mergify bot mentioned this pull request Jun 20, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @nkanazawa1989

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 20, 2024
@github-actions github-actions bot added this to the 1.1.1 milestone Jun 20, 2024
@ElePT ElePT enabled auto-merge June 20, 2024 13:45
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9598604465

Details

  • 1 of 36 (2.78%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 87.182%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/pulse_v2/device_info.py 1 36 2.78%
Files with Coverage Reduction New Missed Lines %
qiskit/visualization/pulse_v2/device_info.py 1 39.71%
crates/qasm2/src/lex.rs 3 92.11%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 9596979842: -0.03%
Covered Lines: 74494
Relevant Lines: 85447

💛 - Coveralls

@ElePT ElePT modified the milestones: 1.1.1, 0.46.2 Jun 20, 2024
@ElePT ElePT added this pull request to the merge queue Jun 20, 2024
Merged via the queue into stable/0.46 with commit d9c40e1 Jun 20, 2024
12 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.46/pr-12608 branch June 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants