Fix bugs with VF2Layout pass and Qiskit Aer 0.13 (backport #11585) #12536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Fix bugs with V2FLayout pass and Qiskit Aer 0.13 * Update qiskit/transpiler/passes/layout/vf2_layout.py Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * test * Update releasenotes/notes/fix-vf2-aer-a7306ce07ea81700.yaml Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> * long lines --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 2b847b8)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 9445779042Details
💛 - Coveralls |
ElePT
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Qiskit Aer 0.13 is incompatible with the pass manager generated by
generate_preset_pass_managerdue to bugs with how VF2Layout pass handles its Target, which does not contain a coupling map or qargs.Details and comments
This fixes these so that VF2 will only use the target generated coupling map if it is not None, and doesn't error from trying to iterate over
target.qargsthat are also None in these cases.This is an automatic backport of pull request #11585 done by [Mergify](https://mergify.com).