Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QuantumCircuit.compose with Index exprs (backport #12396) #12397

Merged
merged 1 commit into from
May 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 14, 2024

Summary

This was an oversight in d6c74c2 (gh-12310), where an ExprVisitor was missed in the testing.

Details and comments

No release note because it's fixing an unreleased bug. I did another check for ExprVisitor classes in Qiskit, and all of them appear to be updated.


This is an automatic backport of pull request #12396 done by Mergify.

This was an oversight in d6c74c2 (gh-12310), where an `ExprVisitor`
was missed in the testing.

(cherry picked from commit 58a383d)
@mergify mergify bot requested a review from a team as a code owner May 14, 2024 13:32
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: None Do not include in changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels May 14, 2024
@github-actions github-actions bot added this to the 1.1.0 milestone May 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9080291033

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.623%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.03%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.2%
crates/qasm2/src/lex.rs 2 92.37%
crates/qasm2/src/parse.rs 12 96.69%
Totals Coverage Status
Change from base Build 9033386902: -0.01%
Covered Lines: 62252
Relevant Lines: 69460

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue May 14, 2024
Merged via the queue into stable/1.1 with commit 6e0eea4 May 14, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.1/pr-12396 branch May 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants