Improve performance of BackendSamplerV2 and EstimatorV2

[t-imamichi]

Summary

Fixes #12290
Addresses Qiskit/qiskit-ibm-runtime#1631 (need to port this PR to qiskit-ibm-runtime to close it)

TODO

• BackendSamplerV2
• BackendEstimatorV2
• reno

Details and comments

Sampler

from timeit import timeit

from qiskit_aer import AerSimulator
from qiskit_ibm_runtime.fake_provider import FakeSherbrooke

from qiskit import QuantumCircuit
from qiskit.primitives import BackendSampler, BackendSamplerV2
from qiskit.transpiler.preset_passmanagers import generate_preset_pass_manager

backend = AerSimulator.from_backend(FakeSherbrooke())
shots = 10000
num_copies = 20


def gen_circuit(num_qubits: int, reps: int):
    qc = QuantumCircuit(num_qubits)
    for _ in range(reps):
        qc.h(range(num_qubits))
        for i in range(0, num_qubits - 1, 2):
            qc.cx(i, i + 1)
    qc.measure_all()
    return qc


def bench_sampler_v1(qc: QuantumCircuit):
    print("\nBackendSamplerV1")
    sampler = BackendSampler(backend)
    print(f"{timeit(lambda: sampler.run([qc] * num_copies, shots=shots).result(), number=1)} sec")


def bench_sampler_v2(qc: QuantumCircuit):
    print("\nBackendSamplerV2")
    sampler = BackendSamplerV2(backend=backend)
    print(f"{timeit(lambda: sampler.run([qc] * num_copies, shots=shots).result(), number=1)} sec")


qc = gen_circuit(5, 5)
pm = generate_preset_pass_manager(optimization_level=2, backend=backend)
qc2 = pm.run(qc)
bench_sampler_v1(qc2)
bench_sampler_v2(qc2)

# main
BackendSamplerV1
0.714542875000916 sec

BackendSamplerV2
9.41767649999747 sec

# this PR
BackendSamplerV1
0.7391576250010985 sec

BackendSamplerV2
0.7517977079987759 sec

---

Estimator

from math import sqrt
from timeit import timeit

from qiskit_aer import AerSimulator
from qiskit_ibm_runtime.fake_provider import FakeSherbrooke

from qiskit import QuantumCircuit
from qiskit.primitives import BackendEstimator, BackendEstimatorV2
from qiskit.transpiler.preset_passmanagers import generate_preset_pass_manager
from qiskit.quantum_info import random_pauli_list, SparsePauliOp

backend = AerSimulator.from_backend(FakeSherbrooke())
shots = 8192
precision = sqrt(1 / shots)
num_qubits = 5
num_copies = 10
seed = 123


def gen_circuit(num_qubits: int, reps: int):
    qc = QuantumCircuit(num_qubits)
    for _ in range(reps):
        qc.h(range(num_qubits))
        for i in range(0, num_qubits - 1, 2):
            qc.cx(i, i + 1)
    return qc


def bench_estimator_v1(qc: QuantumCircuit, obs: SparsePauliOp):
    print("\nBackendEstimatorV1")
    estimator = BackendEstimator(backend)
    print(f"{timeit(lambda: estimator.run([qc] * num_copies, [obs] * num_copies, shots=shots).result(), number=1)} sec")


def bench_estimator_v2(qc: QuantumCircuit, obs: SparsePauliOp):
    print("\nBackendEstimatorV2")
    estimator = BackendEstimatorV2(backend=backend)
    print(f"{timeit(lambda: estimator.run([(qc, obs)] * num_copies, precision=precision).result(), number=1)} sec")


qc = gen_circuit(num_qubits, 5)
pm = generate_preset_pass_manager(optimization_level=2, backend=backend)
qc2 = pm.run(qc)
obs = SparsePauliOp(random_pauli_list(num_qubits, 5, phase=False)).apply_layout(qc2.layout)
bench_estimator_v1(qc2, obs)
bench_estimator_v2(qc2, obs)

# main
BackendEstimatorV1
2.3618681670050137 sec

BackendEstimatorV2
6.282726375000493 sec

# this PR
BackendEstimatorV1
2.3475185420029447 sec

BackendEstimatorV2
2.151061958000355 sec

[coveralls]

Pull Request Test Coverage Report for Build 8802706774

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 88 of 88 (100.0%) changed or added relevant lines in 2 files are covered.
• 27 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.02%) to 89.285%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/primitives/containers/data_bin.py	1	97.92%
crates/qasm2/src/lex.rs	3	92.11%
qiskit/transpiler/preset_passmanagers/builtin_plugins.py	11	96.47%
crates/qasm2/src/parse.rs	12	97.15%

Totals
Change from base Build 8783263005:	0.02%
Covered Lines:	60428
Relevant Lines:	67680

---

💛 - Coveralls

[qiskit-bot]

One or more of the the following people are requested to review this:

• @Qiskit/terra-core
• @ajavadia
• @levbishop
• @t-imamichi

[ihincks]

Thanks for this quick work. I've left a few comments, which I mostly made as I read through the file figuring out what was going on. It all makes sense to me, so LGTM!

[t-imamichi]

I refactored BackendEstimatorV2 by introducing an internal data class _PreprocessedData.

[ihincks]

LGTM