-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in soft_compare #12054
fix typo in soft_compare #12054
Conversation
One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you add a release note to document the fix?
Pull Request Test Coverage Report for Build 8411946291Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
* fix logic in soft_compare * black * add release note * Update releasenotes/notes/fix_soft_compare-3f4148aab3a4606b.yaml --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> (cherry picked from commit 5e7a6d0)
* fix logic in soft_compare * black * add release note * Update releasenotes/notes/fix_soft_compare-3f4148aab3a4606b.yaml --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> (cherry picked from commit 5e7a6d0) Co-authored-by: ewinston <ewinston@us.ibm.com>
This fixes what appears to be a typo in
Instruction.soft_compare
.Summary
This is supposed to return False if the name, number of qubits, number of clbits, or number of parameters are not equal but was ignoring differences in number of qubits and clbits.
Details and comments