Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix improper handling of BindingsArray in SamplerPub.coerce() #11913

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix improper handling of BindingsArray in SamplerPub.coerce() #11913

merged 2 commits into from
Feb 29, 2024

Conversation

ihincks
Copy link
Contributor

@ihincks ihincks commented Feb 28, 2024

Summary

The exact same mistake as in #11871 in the SamplerPub. This PR fixes the issue in the same way and unifies the release note.

Details and comments

@ihincks ihincks added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Feb 28, 2024
@ihincks ihincks added this to the 1.0.2 milestone Feb 28, 2024
@ihincks ihincks requested review from a team as code owners February 28, 2024 15:41
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @t-imamichi

@coveralls
Copy link

coveralls commented Feb 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8090245112

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 43 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.313%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.19%
crates/qasm2/src/parse.rs 6 97.62%
crates/accelerate/src/two_qubit_decompose.rs 7 93.2%
qiskit/transpiler/preset_passmanagers/common.py 11 89.62%
crates/accelerate/src/pauli_exp_val.rs 14 89.03%
Totals Coverage Status
Change from base Build 8080511026: -0.01%
Covered Lines: 59127
Relevant Lines: 66202
💛 - Coveralls

t-imamichi
t-imamichi previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ihincks @t-imamichi
Update releasenotes/notes/fix-pub-coerce-5d13700e15126421.yaml
af9b596 
Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
t-imamichi
t-imamichi approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-imamichi t-imamichi added this pull request to the merge queue Feb 29, 2024
Merged via the queue into Qiskit:main with commit 4e0de54 Feb 29, 2024
12 checks passed
@mergify mergify bot mentioned this pull request Feb 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
@ihincks @mergify
Fix improper handling of BindingsArray in SamplerPub.coerce() (#11913)
fa2558d 
* Fix SamplerPub.coerce too

* Update releasenotes/notes/fix-pub-coerce-5d13700e15126421.yaml

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>

---------

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
(cherry picked from commit 4e0de54)
@ihincks ihincks deleted the primitives/fix-sampler_pub_coerce branch March 1, 2024 14:15
github-merge-queue bot pushed a commit that referenced this pull request Mar 7, 2024
@mergify @ihincks
Fix improper handling of BindingsArray in SamplerPub.coerce() (#11913) (
d4d3873 
#11920)

* Fix SamplerPub.coerce too

* Update releasenotes/notes/fix-pub-coerce-5d13700e15126421.yaml

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>

---------

Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
(cherry picked from commit 4e0de54)

Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-imamichi t-imamichi t-imamichi approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ihincks @qiskit-bot @coveralls @t-imamichi