Fix transpilation of control flow to no hardware #11907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we treated `basis_gates=None` the same as `basis_gates=()` in the hardware check; that is, we treated it as meaning "nothing is allowed", when the intention (and how it's treated elsewhere) is more that "everything is allowed."
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8079103823Details
💛 - Coveralls |
kevinhartman
approved these changes
Feb 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Previously we treated `basis_gates=None` the same as `basis_gates=()` in the hardware check; that is, we treated it as meaning "nothing is allowed", when the intention (and how it's treated elsewhere) is more that "everything is allowed." (cherry picked from commit d47a227)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Previously we treated `basis_gates=None` the same as `basis_gates=()` in the hardware check; that is, we treated it as meaning "nothing is allowed", when the intention (and how it's treated elsewhere) is more that "everything is allowed." (cherry picked from commit d47a227) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we treated
basis_gates=Nonethe same asbasis_gates=()in the hardware check; that is, we treated it as meaning "nothing is allowed", when the intention (and how it's treated elsewhere) is more that "everything is allowed."Details and comments
Marked as stable for 1.0.2, but I could definitely be convinced otherwise.
Fix #11906.