Fixing bug in qcstyle that modified custom style dict
#11874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8082344327Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Durd3nT
changed the title
qcstyle that modified custom style dictqcstyle that modified custom style dict
Cryoris
added
the
Changelog: Bugfix
Cryoris
added
the
stable backport potential
Cryoris
reviewed
Feb 24, 2024
Cryoris
reviewed
Feb 28, 2024
releasenotes/notes/qcstyle-bug-custom-style-dicts-22deab6c602ccd6a.yaml
Outdated
Show resolved
Hide resolved
Cryoris
approved these changes
Feb 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* fixed qcstyle bug that modified style dict, added test * black * ensure that the keys in nested_attrs are not overwritten again * release notes * Update releasenotes/notes/qcstyle-bug-custom-style-dicts-22deab6c602ccd6a.yaml --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> (cherry picked from commit d21127a)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
) * fixed qcstyle bug that modified style dict, added test * black * ensure that the keys in nested_attrs are not overwritten again * release notes * Update releasenotes/notes/qcstyle-bug-custom-style-dicts-22deab6c602ccd6a.yaml --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> (cherry picked from commit d21127a) Co-authored-by: Alexander Miessen <52243504+Durd3nT@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
visualization.circuit.qcstylepopped elements from the style dictionary instead of extracting them, resulting in modyfied style dicts.As discussed with @Cryoris, this PR solves this issue, leaving style dicts untouchted.
Details and comments
Solved the issue described above, added test.