Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qiskit.quantum_info.synthesis for Qiskit 1.0 release #11592

Merged
merged 32 commits into from
Jan 29, 2024

Conversation

ShellyGarion
Copy link
Member

Summary

Remove qiskit.quantum_info.synthesis that has been deprecated in #11460

Details and comments

@ShellyGarion ShellyGarion added on hold Can not fix yet Changelog: Removal Include in the Removed section of the changelog labels Jan 18, 2024
@ShellyGarion ShellyGarion added this to the 1.0.0 milestone Jan 18, 2024
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop

@coveralls
Copy link

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 7692402441

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 71 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.005%) to 89.54%

Files with Coverage Reduction New Missed Lines %
qiskit/primitives/containers/bindings_array.py 1 92.59%
qiskit/transpiler/passes/optimization/commutative_inverse_cancellation.py 2 96.92%
crates/qasm2/src/lex.rs 3 92.44%
qiskit/circuit/gate.py 7 90.91%
qiskit/quantum_info/operators/operator.py 14 94.94%
qiskit/quantum_info/operators/predicates.py 16 64.36%
qiskit/circuit/quantumcircuit.py 28 94.36%
Totals Coverage Status
Change from base Build 7645403491: 0.005%
Covered Lines: 59545
Relevant Lines: 66501

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal looks good, and I believe that we can already remove the on hold tag, right? Now that #11460 has been merged.

@ShellyGarion ShellyGarion removed the on hold Can not fix yet label Jan 29, 2024
@ShellyGarion ShellyGarion added this pull request to the merge queue Jan 29, 2024
Merged via the queue into Qiskit:main with commit 5358110 Jan 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants