Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions in pulse qobj converter #11410

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

nkanazawa1989
Copy link
Contributor

Summary

This PR removes deprecated class methods in the pulse qobj converters.

Details and comments

This also updates internals of ParametricPulseShapes mapping table, because parametric pulse is also removed in this release.

@nkanazawa1989 nkanazawa1989 requested a review from a team as a code owner December 13, 2023 17:38
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@nkanazawa1989 nkanazawa1989 added the Changelog: Removal Include in the Removed section of the changelog label Dec 13, 2023
@coveralls
Copy link

coveralls commented Dec 13, 2023

Pull Request Test Coverage Report for Build 7714505582

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • -2 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 1480 unchanged lines in 111 files lost coverage.
  • Overall coverage increased (+2.0%) to 89.539%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/qobj/converters/pulse_instruction.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/sabre_swap/mod.rs 1 97.42%
crates/qasm2/src/expr.rs 1 93.81%
qiskit/circuit/classical/types/ordering.py 1 94.64%
qiskit/circuit/controlflow/control_flow.py 1 92.86%
qiskit/circuit/delay.py 1 71.19%
qiskit/circuit/library/n_local/excitation_preserving.py 1 95.83%
qiskit/circuit/library/standard_gates/global_phase.py 1 95.83%
qiskit/circuit/library/standard_gates/rx.py 1 98.55%
qiskit/circuit/library/standard_gates/ry.py 1 98.51%
qiskit/circuit/library/standard_gates/ryy.py 1 97.3%
Totals Coverage Status
Change from base Build 7198837138: 2.0%
Covered Lines: 59539
Relevant Lines: 66495

💛 - Coveralls

@nkanazawa1989 nkanazawa1989 added this to the 1.0.0 milestone Jan 9, 2024
@ElePT ElePT self-assigned this Jan 29, 2024
ElePT
ElePT previously approved these changes Jan 30, 2024
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this removal, I added a minor suggestion in the reno, but it could be merged without it.

@ElePT ElePT enabled auto-merge January 30, 2024 16:42
@ElePT ElePT added this pull request to the merge queue Jan 30, 2024
Merged via the queue into Qiskit:main with commit 5060989 Jan 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants