Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ScheduleBlock qpy serialization and use_symengine (backport #11261) #11275

Merged
merged 1 commit into from
Nov 18, 2023

Commits on Nov 18, 2023

  1. Fix issue with ScheduleBlock qpy serialization and use_symengine (#11261

    )
    
    * Fix issue with ScheduleBlock qpy serialization and use_symengine
    
    This commit fixes an issue with the use_symengine flag on the qpy.dump()
    function. Previously in certain conditions a symengine expression that
    was listed in the qpy header as being encoded via symengine was
    incorrectly being serialized using sympy. This would cause a failure on
    deserialialization as the qpy payload was invalid and symengine could
    not parse a symengine representation.
    
    This was originally caught during the development of #10902 as that
    switches the default of use_symengine to ``True`` as it makes symengine
    a hard requirement. This commit splits it out so the isolated fix can be
    backported to 0.45.1.
    
    * Skip symengine test if symengine isn't installed
    
    * Fix skip syntax
    
    * Update releasenotes/notes/fix-schedule-qpy-use-symengine-05ae1dfab73e3ff8.yaml
    
    Co-authored-by: Jake Lishman <jake@binhbar.com>
    
    ---------
    
    Co-authored-by: Jake Lishman <jake@binhbar.com>
    (cherry picked from commit 1dd4f54)
    mtreinish authored and mergify[bot] committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    a4c20fd View commit details
    Browse the repository at this point in the history