Fix top-level switch statements in QuantumCircuit.compose
#10164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The register-mapping code was not being applied to `SwitchCaseOp.target` in the same way that it is for conditions. This commit does not change any behaviour about recursing into _nested_ control-flow blocks, which still likely have problems with composition.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5080209383
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2023
* Fix top-level `switch` statements in `QuantumCircuit.compose` The register-mapping code was not being applied to `SwitchCaseOp.target` in the same way that it is for conditions. This commit does not change any behaviour about recursing into _nested_ control-flow blocks, which still likely have problems with composition. * Apply suggestions from review (cherry picked from commit 76850e1)
jakelishman
added a commit
that referenced
this pull request
May 30, 2023
#10180) * Fix top-level `switch` statements in `QuantumCircuit.compose` The register-mapping code was not being applied to `SwitchCaseOp.target` in the same way that it is for conditions. This commit does not change any behaviour about recursing into _nested_ control-flow blocks, which still likely have problems with composition. * Apply suggestions from review (cherry picked from commit 76850e1) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The register-mapping code was not being applied to
SwitchCaseOp.targetin the same way that it is for conditions. This commit does not change any behaviour about recursing into nested control-flow blocks, which still likely have problems with composition.Details and comments
Fix #10108, at least as far as the top-level issue that's being reported there. See that issue for a further discussion of other problems that stem from the root of that issue.