Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undefined variable #10117

Merged
merged 2 commits into from
May 24, 2023
Merged

Remove undefined variable #10117

merged 2 commits into from
May 24, 2023

Conversation

Randl
Copy link
Contributor

@Randl Randl commented May 16, 2023

Fix #10113

@Randl Randl requested a review from a team as a code owner May 16, 2023 05:33
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label May 16, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 5021608130

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 85.933%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.25%
crates/qasm2/src/lex.rs 3 90.63%
qiskit/circuit/parameterexpression.py 5 87.84%
qiskit/circuit/library/data_preparation/pauli_feature_map.py 7 90.59%
Totals Coverage Status
Change from base Build 4982201939: 0.03%
Covered Lines: 71245
Relevant Lines: 82908

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for finding this and for the quick fix! Would you be able to add a test of the error message and a short bug-fix release note about it?

@Randl Randl requested a review from jakelishman May 19, 2023 10:54
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@jakelishman jakelishman added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels May 24, 2023
@jakelishman jakelishman added this to the 0.24.1 milestone May 24, 2023
@jakelishman jakelishman added this pull request to the merge queue May 24, 2023
Merged via the queue into Qiskit:main with commit 02502b5 May 24, 2023
mergify bot pushed a commit that referenced this pull request May 24, 2023
* Remove undefined variable (fix #10113)

* Add test and bugfix description

(cherry picked from commit 02502b5)
jakelishman pushed a commit that referenced this pull request May 24, 2023
* Remove undefined variable (fix #10113)

* Add test and bugfix description

(cherry picked from commit 02502b5)

Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Undefined variable used in raise
4 participants