This repository has been archived by the owner on May 17, 2024. It is now read-only.
Create advocates filter #1122
Merged
Create advocates filter #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kit.org into feature/update-advocates-page
To reflect our order convention for Vuex: 1. Getters, 2. Mutations, 3. Actions
y4izus
force-pushed
the
feature/update-advocates-page
branch
from
34f9725
to
5365d5c
Compare
eddybrando
requested review from
aasfaw,
abdonrd and
lerongil
as code owners
y4izus
approved these changes
Dec 10, 2020
korgan00
approved these changes
Dec 11, 2020
delapuente
pushed a commit
that referenced
this pull request
Dec 15, 2020
delapuente
pushed a commit
that referenced
this pull request
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a filter for the advocates list based on their regional location.
The filter functionality introduced uses Vuex to store the filter state as well as the computed list of filtered elements, such that the filter and list states will persist even after client-side route navigation, similar to the behaviour of the events filter, as pointed out in #1122 (comment).
In addition, this PR removes the
AppCheckbox.vuecomponent in coordination with its author, @y4izus, since it was only used for styles. Now the styles are defined globally in thecommunity-theme.scssfile since there is no need to scope them as they should be applied for all checkboxes in the website.Closes #1086