Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Set up CI with Azure Pipelines #894

Merged
merged 22 commits into from
May 8, 2020
Merged

Set up CI with Azure Pipelines #894

merged 22 commits into from
May 8, 2020

Conversation

mtreinish
Copy link
Member

This commit adds the CI configuration for running sphinx builds in CI.

@mtreinish
Copy link
Member Author

mtreinish commented May 4, 2020

@nonhermitian
Copy link
Contributor

Many thanks for doing this. Yeah it does work, but not the latest from pip. Only the previous one 12.10.0. did. It is causing more than a few headaches.

There are 2 aqua tutorials that do not work unless CPLEX is installed.
CPLEX is too involved and difficult to install in CI. It is also
proprietary software which prohibits installing it in CI (since a CI
system can't agree to the license terms). Honestly, I'm not entirely
sure why aqua has modules in it that depend solely on having proprietary
software installed, it feels like there should be an open alternative or
if there is one already the tutorial should leverage that. To make the
docs buildable this commit moves these problematic tutorials to the
legacy directory so they're not built/run by default.
There is a bug in the mpl drawer in 0.19.0 (and 0.19.1) release where a
custom instruction does not draw without a label parameter set. This
will need to be fixed in terra, but in the meantime this worksaround the
bug by manually setting a label.
@mtreinish
Copy link
Member Author

The fix for the terra bug which db28762 works around is: Qiskit/qiskit#4389 but that will need to be included in a release before this can be reverted.

@nonhermitian
Copy link
Contributor

Perhaps we just remove the Latex drawing example for now?

@mtreinish
Copy link
Member Author

Yeah, that might be best. Even if I can get it working (which I was pretty sure I did the last time I setup CI around tutorials) the installation of texlive takes a long time because it's so big, several gigabytes. Which can make the CI runs needlessly long depending on networking of the azure node.

@nonhermitian
Copy link
Contributor

@mtreinish all the latex code should now be gone.

@mtreinish
Copy link
Member Author

ok, I've rebased this and removed the latex install bits. Lets see if this can successfully execute all the tutorials now

@mtreinish
Copy link
Member Author

Ugh, more cplex in: https://github.com/Qiskit/qiskit-tutorials/blob/master/tutorials/aqua/optimization/2_converters_for_quadratic_programs.ipynb should I just delete the last 2 sections there or move it to legacy so we don't try to run it?

@nonhermitian
Copy link
Contributor

Just remove it. Once CI is up and running I will tell them to come back and clean

@nonhermitian
Copy link
Contributor

Arg. Another one uses cplex and not just docplex?

@nonhermitian
Copy link
Contributor

Holy moly it works.

@nonhermitian nonhermitian self-requested a review May 8, 2020 17:07
@mtreinish mtreinish merged commit 72099b9 into master May 8, 2020
@mtreinish mtreinish deleted the azure-pipelines branch May 8, 2020 17:15
@mtreinish
Copy link
Member Author

I just added the azure ci to the branch protection rule, it is now required to pass for changes to master

@nonhermitian
Copy link
Contributor

You the man.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants