-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This commit adds the CI configuration for running sphinx builds in CI. [skip ci]
@nonhermitian do the sphinx build work locally for you? Right now this is failing on CPLEX not being installed for aqua: It's honestly a bit too heavyweight to do that in CI: https://github.com/Qiskit/qiskit-aqua/blob/master/qiskit/aqua/algorithms/minimum_eigen_solvers/cplex/__init__.py#L16 |
Many thanks for doing this. Yeah it does work, but not the latest from pip. Only the previous one 12.10.0. did. It is causing more than a few headaches. |
There are 2 aqua tutorials that do not work unless CPLEX is installed. CPLEX is too involved and difficult to install in CI. It is also proprietary software which prohibits installing it in CI (since a CI system can't agree to the license terms). Honestly, I'm not entirely sure why aqua has modules in it that depend solely on having proprietary software installed, it feels like there should be an open alternative or if there is one already the tutorial should leverage that. To make the docs buildable this commit moves these problematic tutorials to the legacy directory so they're not built/run by default.
There is a bug in the mpl drawer in 0.19.0 (and 0.19.1) release where a custom instruction does not draw without a label parameter set. This will need to be fixed in terra, but in the meantime this worksaround the bug by manually setting a label.
The fix for the terra bug which db28762 works around is: Qiskit/qiskit#4389 but that will need to be included in a release before this can be reverted. |
Perhaps we just remove the Latex drawing example for now? |
Yeah, that might be best. Even if I can get it working (which I was pretty sure I did the last time I setup CI around tutorials) the installation of texlive takes a long time because it's so big, several gigabytes. Which can make the CI runs needlessly long depending on networking of the azure node. |
@mtreinish all the latex code should now be gone. |
ok, I've rebased this and removed the latex install bits. Lets see if this can successfully execute all the tutorials now |
Ugh, more cplex in: https://github.com/Qiskit/qiskit-tutorials/blob/master/tutorials/aqua/optimization/2_converters_for_quadratic_programs.ipynb should I just delete the last 2 sections there or move it to legacy so we don't try to run it? |
Just remove it. Once CI is up and running I will tell them to come back and clean |
Arg. Another one uses cplex and not just docplex? |
Holy moly it works. |
I just added the azure ci to the branch protection rule, it is now required to pass for changes to master |
You the man. |
This commit adds the CI configuration for running sphinx builds in CI.