This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Typo and duplications in 04_transpiler_passes_and_passmanager.ipynb #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the next line gets `dag.op_nodes()[3]`
The `draw` method of `Circuit` is drawing twice in Jupyter notebooks: once from mpl plotting, and once from displaying the returned object. A fix for this is a local variable named `fig` for example. Then, only the mpl plotting is displayed.
Since `circuits = [log_circ, log_circ]`
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I couldn't push to your branch, so closing in favor of #1494. Thanks for making Qiskit better! Pardon the delay in review also. |
Eric-Arellano
added a commit
that referenced
this pull request
Aug 21, 2023
Built on top of #1239. --------- Co-authored-by: Bochen "Daniel" Tan <33230390+tbcdebug@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correcting typo and duplications in 04_transpiler_passes_and_passmanager.ipynb
The detail to each individual correction is in its commit title and comment.
Details and comments