feat: job provider list endpoint #1583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
requested changes
Feb 14, 2025
| @@ -32,6 +33,20 @@ def get_job_by_id(self, job_id: str) -> Job: | |||
|
|
|||
| return result_queryset | |||
|
|
|||
| def get_program_jobs(self, program: Program, ordering="-created") -> List[Job]: | |||
There was a problem hiding this comment.
Remember that we decided to start using function instead of program in our code for all the new stuff to try to use the new nomenclature. So let's rename this method to get_jobs_from_function or something like that, @paaragon
| @@ -145,6 +154,65 @@ def list(self, request): | |||
| serializer = self.get_serializer_job_without_result(queryset, many=True) | |||
| return Response(serializer.data) | |||
|
|
|||
| @action(methods=["GET"], detail=False, url_path="provider") | |||
| def provider_list(self, request): | |||
There was a problem hiding this comment.
Remember @paaragon that you need to include this new end-point in the v1 too:
https://github.com/Qiskit/qiskit-serverless/blob/main/gateway/api/v1/views/jobs.py
Add to it the swagger configuration also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a new endpoint to allow providers to retrieve all jobs from a function they own.
Details and comments
The endpoint support pagination and jobs are returned without results