add filters to /job and /program #1466
Conversation
|
Looks good! I'll try to run test it Monday for final approval :) Thanks Aki! |
There was a problem hiding this comment.
I see the logic fine @akihikokuroda but I would like to propose a change in the logic as I was mentioning here: #1456 (comment)
Instead to use catalog & serverless I would use user & provider as Iskandar proposed. The reason behind this is that If other client would like to retrieve user or partner would need to use catalog or serverless what probably it has not much sense.
Apart from that I see everything ok 👍
|
@Tansito The filter values are used (sent) by the current qiskit_ibm_catalog side. So they must be these values until the catalog client is changed. They are not visible from the users so we can create a refactor PR later and fix both client and gateway at the same time. |
|
Ooooh, ok, understood I didn't know that the catalog was already with those values. |
|
Don't wait for my approval to merge it @akihikokuroda , what I saw I saw it ok and if one of us approves it it's more than enough 👍 |
Summary
fix #1456
Details and comments