Add dependency parsing grammar for gateway allowlist #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The gateway pod seems to be restarting in the k8s test, not sure why yet |
|
huh, it's getting hit with an OOMKilled error... |
|
ok, bumping the resource limits on the gateway fixed the issue |
|
Good to know because we had the same problem with the scheduler Wed 😂 |
|
Add it |
psschwei
force-pushed
the
dependency-parsing
branch
from
1ab46e0
to
0e19e07
Compare
Tansito
reviewed
Sep 10, 2024
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> This PR adds the dependency specification grammar from PEP 508 (https://peps.python.org/pep-0508/) to use when validating dependencies via the allowlist. As a temporary measure, it also simplifies the check to only consider the dependency and not a specific version. As such, it has dropped the test for related to dependency version. Future work should be done to convert the allowlist file from JSON to the standard requirements.txt format, which would allow for easier version checking.
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
psschwei
force-pushed
the
dependency-parsing
branch
from
f60d468
to
02950ff
Compare
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Tansito
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #369
This PR adds the dependency specification grammar from PEP
508 (https://peps.python.org/pep-0508/) to use when validating
dependencies via the allowlist.
As a temporary measure, it also simplifies the check to only consider
the dependency and not a specific version. As such, it has dropped the
test for related to dependency version.
Future work should be done to convert the allowlist file from JSON to
the standard requirements.txt format, which would allow for easier
version checking.
Details and comments