Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limitate accesible registries and implement a mock provider #1345

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Limitate accesible registries and implement a mock provider #1345

merged 9 commits into from
Jun 3, 2024

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented May 28, 2024 •
edited
Loading

Summary

Close #1340 , #1342

This PR accomplish two requirements:

  • It limitates the usage of Docker images to those users that has access to a provider
  • With mockuser a mockprovider is created for local testing so now everyone can run docker images locally if they use mockuser

Details and comments

  • I just added a validation where if the user sets an image needs to specify a provider
  • With mockprovider mockgroup is created too with VIEW and RUN permissions
  • Update list method to return the provider.name. I forgot to add it before.

@Tansito Tansito changed the title Limitate accesible registries Limitate accesible registries and implement a mock provider May 28, 2024
@Tansito Tansito linked an issue May 28, 2024 that may be closed by this pull request
Limitate the registries that the application can use #1342
Closed
@Tansito Tansito marked this pull request as ready for review May 30, 2024 16:57
akihikokuroda
akihikokuroda approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tansito Tansito merged commit 0bbc24f into main Jun 3, 2024
15 checks passed
@Tansito Tansito deleted the mock-provider branch June 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihikokuroda akihikokuroda akihikokuroda approved these changes

@IceKhan13 IceKhan13 Awaiting requested review from IceKhan13

@psschwei psschwei Awaiting requested review from psschwei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limitate the registries that the application can use Implement a mock provider
2 participants
@Tansito @akihikokuroda