Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add h5 extension #1135

Merged
merged 1 commit into from
Dec 7, 2023
Merged

add h5 extension #1135

merged 1 commit into from
Dec 7, 2023

Conversation

akihikokuroda
Copy link
Collaborator

Summary

Fix #1113

Details and comments

This just adds h5 file extension in the files api out.

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@Tansito
Copy link
Member

Tansito commented Dec 6, 2023

@akihikokuroda just to confirm, I'm not 100% sure. Did you try to do a migration?

python manage.py makemigrations

FYI: https://docs.djangoproject.com/en/4.2/topics/migrations/

I don't know if it applies when we add a new end of file but just to be sure.

@akihikokuroda
Copy link
Collaborator Author

@Tansito I didn't do it. This change doesn't affect the models so it should be fine.

@Tansito
Copy link
Member

Tansito commented Dec 6, 2023

Oh, I didn't know that we were filtering in two different places the extension:

https://github.com/Qiskit-Extensions/quantum-serverless/blob/main/gateway/api/models.py#L66

Something to take a look to improve, definitely.

@Tansito
Copy link
Member

Tansito commented Dec 6, 2023

Well, correct me if I'm wrong @akihikokuroda . Maybe this is not needed (my comment)? We are not storing a QiskitPattern, this is just to upload files as resources, isn't it?

@akihikokuroda
Copy link
Collaborator Author

akihikokuroda commented Dec 6, 2023

@Tansito Yes, that's correct. The model attribute is for the tar file that has the program working directory contents created and sent to ray node internally. It is not the file for the download.

Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@IceKhan13 IceKhan13 merged commit 21b5c29 into Qiskit:main Dec 7, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files download: support for h5 and other popular formats.
3 participants