Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support LayerErrors with unknown error channels #1942

Merged
merged 22 commits into from
Sep 23, 2024
Merged

Adding support LayerErrors with unknown error channels #1942

merged 22 commits into from
Sep 23, 2024

Conversation

SamFerracin
Copy link
Collaborator

Summary

This lays the ground for including more information on how the circuit is broken into layers server-side.

chriseclectic
chriseclectic reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Just a few nit pics and some suggestions about allowing user None values

qiskit_ibm_runtime/options/resilience_options.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/utils/noise_learner_result.py Show resolved Hide resolved
qiskit_ibm_runtime/utils/noise_learner_result.py Outdated Show resolved Hide resolved
test/unit/test_data_serialization.py Show resolved Hide resolved
SamFerracin and others added 3 commits September 23, 2024 15:03
@SamFerracin SamFerracin merged commit 825b994 into Qiskit:main Sep 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseclectic chriseclectic chriseclectic left review comments

@joshuasn joshuasn joshuasn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamFerracin @chriseclectic @joshuasn