Migrate integration tests to test_eagle #1828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/integration/test_noise_learner.py
# Conflicts: # test/ibm_test_case.py # test/integration/test_estimator.py # test/integration/test_job.py # test/integration/test_options.py # test/integration/test_sampler.py # test/integration/test_session.py
# Conflicts: # test/integration/test_noise_learner.py
kt474
reviewed
Sep 17, 2024
test/decorators.py
Outdated
| if not all([channel, token, url]): | ||
| print(f"Channel: {channel}, Token: {token}, url: {url}") |
There was a problem hiding this comment.
Suggested change
| print(f"Channel: {channel}, Token: {token}, url: {url}") |
| estimator = EstimatorV2(session=session) | ||
| estimator.options.environment = {"job_tags": [".".join(self.id().split(".")[-2:])]} |
There was a problem hiding this comment.
Do we need job tags in this test?
test/integration/test_ibm_job.py
Outdated
| @@ -117,7 +122,7 @@ def test_retrieve_completed_jobs(self): | |||
| backend_name=self.sim_backend.name, limit=3, pending=False | |||
| ) | |||
| for job in completed_job_list: | |||
| self.assertTrue(job.status() in ["DONE", "CANCELLED", "ERROR"]) | |||
| self.assertTrue(job.status() in [JobStatus.DONE, JobStatus.CANCELLED, JobStatus.ERROR]) | |||
There was a problem hiding this comment.
Shouldn't the job statuses be strings? All jobs should be RuntimeJobV2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1683
Details and comments
Before merging, the
QISKIT_IBM_DEVICEvar should be added for all the environments we run the integration tests. Also, theQISKIT_IBM_INSTANCEvalue should be verified.