Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable branch #1387

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Update stable branch #1387

merged 4 commits into from
Feb 7, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Feb 7, 2024

Summary

Details and comments

Fixes #

kt474 and others added 4 commits February 6, 2024 10:33
…ons.from_backend` for both `Backend versions` (#1383)

* porting qiskit-ibm-provider/pull/787

* porting qiskit-ibm-provider/pull/787

* black

* oops

* monkey patch Qiskit/qiskit#11727

* black lynt

* mypy

---------

Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
* Cast use_symengine input to a bool

This commit works around a bug in Qiskit 0.45.x, 0.46.0, and 1.0.0rc1
with the `use_symengine` flag on `qpy.dump()`. The dump function has a
bug when it receives a truthy value instead of a bool literal that it
will generate a corrupt qpy because of a mismatch between how the
encoding was processed (the encoding is incorrectly set to sympy in the
file header but uses symengine encoding in the actual body of the
circuit.  This is being fixed in Qiskit/qiskit#11730 for 1.0.0, and will
be backported to 0.46.1. But to ensure compatibility with 0.45.x, 0.46.0,
and 1.0.0rc1 while waiting for those releases we can workaround this by
just casting the value to a boolean.

* Fix mypy failures

* Mypy fixes again
@kt474 kt474 merged commit e975e16 into stable/0.19 Feb 7, 2024
21 of 22 checks passed
@kt474 kt474 temporarily deployed to ibm-quantum-production February 7, 2024 15:24 — with GitHub Actions Inactive
@kt474 kt474 temporarily deployed to ibm-cloud-production February 7, 2024 15:24 — with GitHub Actions Inactive
@kt474 kt474 had a problem deploying to ibm-quantum-production February 7, 2024 15:30 — with GitHub Actions Failure
@kt474 kt474 had a problem deploying to ibm-cloud-production February 7, 2024 15:30 — with GitHub Actions Failure
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7817043463

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • -7 of 56 (87.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.213%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/utils/json.py 1 2 50.0%
qiskit_ibm_runtime/transpiler/passes/scheduling/utils.py 47 53 88.68%
Totals Coverage Status
Change from base Build 7801806393: 0.1%
Covered Lines: 4889
Relevant Lines: 6172

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants