Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Deprecate qiskit-ibm-provider #832

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Apr 10, 2024

Summary

Fixes #745

Replacing jupyter-execute with code-block because of issues with jupyter sphinx - related to Qiskit/qiskit#9346

Details and comments

@kt474 kt474 added the Changelog: Deprecation Include in Deprecated section of changelog label Apr 10, 2024
@jyu00
Copy link
Collaborator

jyu00 commented Apr 15, 2024

@kt474 can you also update the README? Like we did for ibmq-provider.

@kt474 kt474 requested a review from jyu00 April 16, 2024 03:02
@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8713799347

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 43.392%

Totals Coverage Status
Change from base Build 8253918978: 0.02%
Covered Lines: 2945
Relevant Lines: 6787

💛 - Coveralls

Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add (NOW DEPRECATED) to the first line of the README? Similar to what ibmq-provider has. The rest looks good.

@kt474 kt474 merged commit cc26971 into Qiskit:main Apr 16, 2024
15 checks passed
@kt474 kt474 deleted the deprecate-qiskit-ibm-provider branch April 16, 2024 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: Deprecation Include in Deprecated section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate qiskit-ibm-provider
3 participants