Fix for https://github.com/Qiskit/qiskit-aer/issues/2234 #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling State::probabilities() crashes for the MPS simulator
Summary
Trying to get all probabilities for a MPS simulator by calling State::probabilities() resulted in a crash.
Details and comments
The call ended up in
MPS::find_centralized_indiceswhere the crash occurred because of a conversion of -1 to unsigned int, resulting in a loop over invalid indices. The fix simply adds all qubits inop.qubitsinState::probabilities(), to prevent the issue.