-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Qiskit 1.2 #2201
Merged
Merged
Fixes for Qiskit 1.2 #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-imamichi
reviewed
Aug 13, 2024
qiskit_aer/backends/aer_simulator.py
Outdated
memory=False, | ||
max_shots=int(1e6), | ||
coupling_map=( | ||
configuration = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a dataclass for configuration
to avoid a breaking change.
It would be nice to raise a deprecation warning to access properties
instead of an error.
backend = AerSimulator()
# 0.14.2
backend.properties() # None
backend.configuration().basis_gates # ['ccx',...]
backend.configuration()["basis_gates"] # TypeError: 'QasmBackendConfiguration' object is not subscriptable
# this PR
backend.properties() # AttributeError: 'AerSimulator' object has no attribute 'properties'
backend.configuration().basis_gates # AttributeError: 'dict' object has no attribute 'basis_gates'
backend.configuration()["basis_gates"] # ['ccx',...]
doichanj
added
stable-backport-potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: Deprecation
Include in Deprecated section of changelog
labels
Aug 14, 2024
doichanj
added
the
Changelog: Bugfix
Include in the Fixed section of the changelog
label
Aug 14, 2024
hhorii
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the Fixed section of the changelog
Changelog: Deprecation
Include in Deprecated section of changelog
stable-backport-potential
The issue or PR might be minimal and/or import enough to backport to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is fixes for Qiskit 1.2
Details and comments
This PR includes
qiskit.providers.models
, which it is used by Aer #2197AerSimulator.from_backend()
will be removed in Qiskit 2.0UnitaryGate
orDiagonalGate
maybe issue in QIskit Transpile fails when multiple circuits with UnitaryGate or DiagonalGate qiskit#12953#2187 is also required for Qiskit 1.2 support