Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add save_expval to extended_stabilizer #2161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Add save_expval to extended_stabilizer #2161

wants to merge 2 commits into from

Conversation

doichanj
Copy link
Collaborator

@doichanj doichanj commented Jun 3, 2024 •
edited
Loading

Summary

This PR adds (enables) save_expval and save_expval_var to extended_stabilizer requested by #2121

Details and comments

save_expval and save_expval_var in extended_stabilizer were disabled because there were bug in expectation values calculation.
I found 3 issues:

  • save_expval_var was not included in State::check_measurement_opt
  • Phase for Y gate was not updated
  • The same random number generator was used in the parallel loop in Runner::norm_estimation

Now it works for cliffords cases, but it still does not work for non-cliffords cases

@doichanj doichanj added Changelog: New Feature Include in the Added section of the changelog Changelog: Bugfix Include in the Fixed section of the changelog labels Jun 3, 2024
@doichanj doichanj mentioned this pull request Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doichanj