Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: permit the disabling of Sz conservation #52

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

mrossinek
Copy link
Member

This PR allows an end-user to disable the Sz conservation in a TeNPy-based dynamic MPF calculation.

Previously, we did not support this as stated in #36.
TeNPy's XXZChain2 class actually hard-codes the Sz conservation, contrary to my statement in #36.
The user can do so manually with a custom subclass until TeNPy supports this natively.

With this PR, the user has full flexibility over enabling/disabling Sz conservation.

Closes #36.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12635192604

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12634786731: 0.0%
Covered Lines: 581
Relevant Lines: 581

💛 - Coveralls

@mrossinek mrossinek merged commit 83f9e6d into main Jan 6, 2025
15 checks passed
@mrossinek mrossinek deleted the conserve-none branch January 6, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tenpy] lift the conserve="Sz" requirement
2 participants