Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run black on codebase #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tony
Copy link

@tony tony commented Aug 10, 2020

Complies with PEP 8 and 257, fixes indentation to 4 spaces.

See also: https://black.readthedocs.io/en/stable/the_black_code_style.html, Qencode-Corp/qencode-api-python-client#1

(assuming formatting the codebase with black is okay)

To recreate if you'd like to try your own PR to format and merge that

pip install -U black
black sample-code setup.py tests sample-code qencode3 --skip-string-normalization

String normalization

Black will change single quotes to double quotes by default.

I turned it off to just keep the changes to structural formatting in this PR, I'm happy to revise the PR if it's preferred to have strings formatted as well

Remove skip-string-normalization from pyproject.toml and the above example command and rerun the formatter. All strings will now be consistently using double quotes.

Complies with PEP 8 and 257, fixes indentation to 4 spaces.

See also: https://black.readthedocs.io/en/stable/the_black_code_style.html
This can be turned off if its okay for black to turn single quotes to
double quotes. To make the changes more minimal, skip for now.
@tony tony force-pushed the tn-black-formatting branch from 1fab9a3 to dec4f29 Compare August 10, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant