refactor!: outside placement and adjustment for qbx_properties #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added outside placement - Corrected for qbx_properties - Added types - Fixed bug of objects spawning on top of each other
- Allows for defining where plants are allowed to spawn - Converted stages to array
- Added outside placement - Adjusted for qbx_properties
|
The linter test failed because of the source global being only available server side to its knowledge. I submitted a PR to Illenium's linter to fix that |
Manason
approved these changes
Sep 7, 2024
mafewtm
approved these changes
Sep 7, 2024
|
All comments have been addressed |
|
If you run the linter again, it should succeed now, my PR got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option in the shared config to allow for outside placement of weed too. It's also adjusted to work with qbx_properties instead of the archived qbx_houses and the SQL has changed to be a bit more understandable and work with the new option. A migration SQL file is provided too.
Checklist