Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier information API #72

Merged
merged 5 commits into from
Feb 11, 2022
Merged

Easier information API #72

merged 5 commits into from
Feb 11, 2022

Conversation

osopardo1
Copy link
Member

@osopardo1 osopardo1 commented Feb 4, 2022 •
edited
Loading

Related to #43, this PR adds new methods to QbeastTable that allows both developers and users to understand the metadata of qbeast, such as:

val qbeastTable = QbeastTable.forPath(spark, path)
qbeastTable.indexedColumns() // Outputs the actual indexed columns
qbeastTable.cubeSize() // Outputs the actual cube size
qbeastTable.revisionsID() // Outputs the list of revision identifiers available for a table
qbeastTable.latestRevisionID() // Outputs the latest revision identifier available for a table

Any suggestion is welcome! Feel free to ask for metadata information that would be relevant to you 😄

@osopardo1 osopardo1 marked this pull request as ready for review February 9, 2022 09:17
eavilaes
eavilaes suggested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@eavilaes eavilaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and nice tests! Just a couple of comments, really small things:

src/main/scala/io/qbeast/spark/QbeastTable.scala Outdated Show resolved Hide resolved
src/main/scala/io/qbeast/spark/QbeastTable.scala Outdated Show resolved Hide resolved
src/main/scala/io/qbeast/spark/QbeastTable.scala Outdated Show resolved Hide resolved
@osopardo1 osopardo1 requested a review from eavilaes February 9, 2022 10:59
cugni
cugni requested changes Feb 9, 2022
View reviewed changes
src/main/scala/io/qbeast/spark/QbeastTable.scala Outdated Show resolved Hide resolved
src/main/scala/io/qbeast/spark/QbeastTable.scala Outdated Show resolved Hide resolved
@osopardo1 osopardo1 requested a review from cugni February 9, 2022 15:12
cugni
cugni approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@cugni cugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOP! 🔝

@osopardo1 osopardo1 merged commit a435d7d into Qbeast-io:main Feb 11, 2022
@osopardo1 osopardo1 mentioned this pull request Feb 11, 2022
Closed
@osopardo1 osopardo1 deleted the 43-easier-information-api branch February 26, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cugni cugni cugni approved these changes

@eavilaes eavilaes eavilaes approved these changes

@Jiaweihu08 Jiaweihu08 Jiaweihu08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osopardo1 @cugni @eavilaes @Jiaweihu08