Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 302: Add Logging information to the Contributing guide #308

Merged
merged 4 commits into from
May 2, 2024

Conversation

osopardo1
Copy link
Member

@osopardo1 osopardo1 commented Apr 9, 2024

Description

This PR adds Logging documentation into the CONTRIBUTING.md file.

Fixes #302

Type of change

Documentation update.

@osopardo1 osopardo1 requested review from cdelfosse and fpj April 9, 2024 07:40
@osopardo1 osopardo1 changed the title Issue 302: Add basic Logging information to the Contributing guide Issue 302: Add Logging information to the Contributing guide Apr 9, 2024
Copy link
Contributor

@cdelfosse cdelfosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We should also add "Add logging" in the PR template checklist.

@osopardo1
Copy link
Member Author

LGTM. We should also add "Add logging" in the PR template checklist.

Sure! Done in be818ce

Copy link
Contributor

@fpj fpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo :-)

@osopardo1 osopardo1 requested a review from fpj April 16, 2024 10:38
@osopardo1 osopardo1 requested a review from fpj April 29, 2024 12:33
Copy link
Contributor

@fpj fpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, lgtm

@fpj fpj merged commit 6075355 into Qbeast-io:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging levels to the Contribution Guide
3 participants