Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

267 Remove redundant metadata creations #268

Merged

Conversation

Jiaweihu08
Copy link
Member

@Jiaweihu08 Jiaweihu08 commented Feb 9, 2024

Description

Fixes #267

We make no metadata updates unless a write involves revision change or replication.
An appends that's unaware of the Replication that happened after its own write started will cause inconsistencies.

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fix has been committed following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

How Has This Been Tested?

  • An Append that neither changes the schema nor updates the Revision should not create metadata log entry.

@Jiaweihu08 Jiaweihu08 added the type: bug Something isn't working label Feb 9, 2024
@Jiaweihu08 Jiaweihu08 requested a review from osopardo1 February 9, 2024 15:44
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0e372f) 91.06% compared to head (6bb8b0a) 91.05%.
Report is 9 commits behind head on main-1.0.0.

❗ Current head 6bb8b0a differs from pull request most recent head 4baea91. Consider uploading reports for the commit 4baea91 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           main-1.0.0     #268      +/-   ##
==============================================
- Coverage       91.06%   91.05%   -0.01%     
==============================================
  Files              95       95              
  Lines            2562     2561       -1     
  Branches          321      314       -7     
==============================================
- Hits             2333     2332       -1     
  Misses            229      229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiaweihu08 Jiaweihu08 merged commit 04b5d18 into Qbeast-io:main-1.0.0 Feb 13, 2024
1 check passed
@Jiaweihu08 Jiaweihu08 deleted the 267-remove-redundant-metadata branch February 13, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants