Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Seq to Set to improve time complexity #266

Merged

Conversation

Jiaweihu08
Copy link
Member

@Jiaweihu08 Jiaweihu08 commented Feb 7, 2024

Description

Convert the Seq[String] to Set[String] to reduce time complexity when filtering.

Type of change

Improvement

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fix has been committed following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

@Jiaweihu08 Jiaweihu08 requested a review from osopardo1 February 7, 2024 19:03
@Jiaweihu08 Jiaweihu08 added the type: enhancement Improvement of existing feature or code label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bdc302) 91.04% compared to head (d0e372f) 91.06%.
Report is 9 commits behind head on main-1.0.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-1.0.0     #266      +/-   ##
==============================================
+ Coverage       91.04%   91.06%   +0.01%     
==============================================
  Files              95       95              
  Lines            2557     2562       +5     
  Branches          325      321       -4     
==============================================
+ Hits             2328     2333       +5     
  Misses            229      229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osopardo1
Copy link
Member

LGTM!

@osopardo1 osopardo1 merged commit 6a780ea into Qbeast-io:main-1.0.0 Feb 8, 2024
3 checks passed
@Jiaweihu08 Jiaweihu08 deleted the fix-optimize-file-filtering branch February 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing feature or code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants