-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CREATE EXTERNAL TABLE without OPTIONS #248
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 91.76% 91.78% +0.02%
==========================================
Files 91 91
Lines 2258 2264 +6
Branches 167 172 +5
==========================================
+ Hits 2072 2078 +6
Misses 186 186 ☔ View full report in Codecov by Sentry. |
Adding some tests I've found a weird behavior when passing Options/Paramaters/Properties back and forth. For example, if a Table already exists with Options A and B, the user can:
In the second case, options A and B weren't passed to the save methods, and subsequently not overridden. Fixing them!! |
Main added features: - Rollup - Domain-driven appends - Auto-indexing - Multi-block file Additionally, this merge performs the following: - Updates documentation according to the new version. - Removes unnecessary classes (e.g., CubeInfo). - Resolves inconsistencies with the Auto Indexing #247 and CREATE EXTERNAL TABLE without OPTIONS #248 changes. - compact() is no longer necessary, but we are leaving it to avoid additional changes to the staging area. We have issue 294 open to resolve it later. --------- Co-authored-by: Alexey Akimov Co-authored-by: Jiawei Co-authored-by: osopardo1 Co-authored-by: osopardo1 Co-authored-by: SrTangente Co-authored-by: SrTangente Co-authored-by: jiawei
Description
Fixes #246
Type of change
Allows the creation of an already physically formatted Qbeast Table without the need to specify the options
columnsToIndex
orcubeSize
. In case the table is external, exists, and has Qbeast Metadata, it loads the required parameters from theQbeastSnapshot
.Let's see an example:
Checklist:
Here is the list of things you should do before submitting this pull request:
How Has This Been Tested? (Optional)
It is tested in
QbeastSQLIntegrationTest
.