-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for indexing Date data types #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 91.68% 91.77% +0.08%
==========================================
Files 62 62
Lines 1432 1446 +14
Branches 106 108 +2
==========================================
+ Hits 1313 1327 +14
Misses 119 119
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
osopardo1
reviewed
Aug 31, 2022
core/src/main/scala/io/qbeast/core/transform/LinearTransformation.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/io/qbeast/core/transform/TransformerTest.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/io/qbeast/core/transform/Transformation.scala
Outdated
Show resolved
Hide resolved
Well done! Just a few more comments/questions:
|
osopardo1
reviewed
Aug 31, 2022
Adricu8
commented
Sep 1, 2022
core/src/test/scala/io/qbeast/core/transform/TransformerTest.scala
Outdated
Show resolved
Hide resolved
Looks good! |
osopardo1
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for indexing Datetime data type in qbeast-spark.
In reference to issue.
Type of change
It is an enhancement that would allow for Datetime data type to be indexed without the need of a workaround like casting the value to a Long type or similar.
Spark has two date data types, we could add support for both.
More elaborated explanation and guidelines regarding the addition of new types here
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Test Configuration: