-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify index metrics #118
Merged
Merged
Modify index metrics #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good! The only missing part is to document what are those metrics in the |
osopardo1
approved these changes
Jul 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 89.13% 90.71% +1.58%
==========================================
Files 60 60
Lines 1307 1325 +18
Branches 98 102 +4
==========================================
+ Hits 1165 1202 +37
+ Misses 142 123 -19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify index metrics computation. Some others statistics are added since during many experiments they are found useful.
Changes made:
L1
,L2
errors to measure how inner cube sizes deviate from thedesiredCubeSize
, values are between 0 and 1.depthOnBalance
using geometrics sum since many indexes don't have a high number of levelsHow to use: