Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSM2 systems #48

Merged
merged 64 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
e208d76
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into metro
yalinli2 Oct 5, 2023
d2fe63a
Merge branch 'bsm2' of https://github.com/QSD-Group/EXPOsan into metro
yalinli2 Oct 14, 2023
89ebdfe
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into metro
yalinli2 Oct 14, 2023
507e10f
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into metro
yalinli2 Oct 14, 2023
7ad9268
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into metro
yalinli2 Oct 14, 2023
e6774b8
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into metro
yalinli2 Nov 9, 2023
5b3f06b
update readme with new figs
yalinli2 Nov 12, 2023
c1f1469
higher res figure
yalinli2 Nov 12, 2023
975860f
update bsm2 config
yalinli2 Nov 13, 2023
c91a29c
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Nov 17, 2023
54fe429
Merge branch 'metro' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Nov 21, 2023
62d1ab9
add validation system for asm2adm
yalinli2 Nov 21, 2023
068f2d5
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Dec 31, 2023
e7623f5
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Jan 12, 2024
47fb81f
add ADM2ASM validation script
yalinli2 Jan 15, 2024
e359b99
Update validation_asm2adm.py
joyxyz1994 Jan 15, 2024
bcf35b3
debug checkpoint
joyxyz1994 Jan 16, 2024
6366201
debug adm-asm interface
joyxyz1994 Jan 16, 2024
b585b40
update results
joyxyz1994 Jan 18, 2024
6bdedd1
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Feb 5, 2024
d94de33
Merge branch 'bsm2' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Feb 5, 2024
3904391
add check point, changes unfinished
yalinli2 Feb 13, 2024
704d732
resolve conflicts
yalinli2 Feb 13, 2024
53c8f51
better comparison for ASM1/ADM1 interface comparison
yalinli2 Apr 14, 2024
1d3db53
minor updates of system configuration, current setup lead to negative…
yalinli2 Apr 14, 2024
05027f0
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Apr 14, 2024
763e3c5
checkpoint backup for data sheet
yalinli2 Apr 15, 2024
dab8cf2
remove redundant data sheet
yalinli2 Apr 15, 2024
fc302e2
update bsm2 system config, results not correct
yalinli2 Apr 15, 2024
36b0685
debug bsm2
joyxyz1994 Apr 17, 2024
63e4b95
add tests for ADM1 interfaces
joyxyz1994 Apr 23, 2024
5639e7b
bsm2 uses alternative asm1 rate equations
joyxyz1994 Apr 25, 2024
6736395
add bsm2 tests
joyxyz1994 Apr 26, 2024
9e06907
Update test_bsm2.py
joyxyz1994 May 9, 2024
3c64179
Merge branch 'main' into bsm2
joyxyz1994 May 9, 2024
2bd2b2d
resolve failed test
joyxyz1994 May 9, 2024
dc6c73b
ASM1 initial conditions differ from steady state
joyxyz1994 May 16, 2024
5aa3d19
clean up bsm2 system
joyxyz1994 May 16, 2024
ff1300b
update rtol for short t_span & different initial condition
joyxyz1994 May 16, 2024
4cec3b5
update bsm2 test
joyxyz1994 May 21, 2024
6588d22
alternative BSM2 unit operation
joyxyz1994 May 30, 2024
9a21632
test system for ADM1p
joyxyz1994 Jun 14, 2024
587567a
BSM2 with MMP and gas stripping in AS process
joyxyz1994 Jun 19, 2024
ab6019d
checkpoint
joyxyz1994 Jun 24, 2024
14f3148
Update test_adm1p_interfaces.py
joyxyz1994 Jun 25, 2024
1853656
checkpoint
joyxyz1994 Jun 27, 2024
b82618c
checkpoint
joyxyz1994 Jul 18, 2024
9fe763a
enable BSM1 simulation w/ ASM2d
joyxyz1994 Jul 23, 2024
0db5932
use CSTR instead of PFR
joyxyz1994 Jul 23, 2024
cb6139c
add test for bsm1 with asm2d
joyxyz1994 Jul 25, 2024
93eded7
checkpoint
joyxyz1994 Aug 13, 2024
d4f1e8f
Create build-dev.yml
joyxyz1994 Aug 14, 2024
c18cc75
name fix
joyxyz1994 Aug 14, 2024
5ceb724
add test for mASM2d-ADM1p interface
joyxyz1994 Aug 22, 2024
c566f6b
Update test_junctions.py
joyxyz1994 Aug 22, 2024
8631e2b
minor update
joyxyz1994 Aug 22, 2024
cde6715
working bsm2p settings
joyxyz1994 Sep 27, 2024
405a86d
changed default temperature
joyxyz1994 Oct 15, 2024
b9cffb5
Merge branch 'main' into bsm2
joyxyz1994 Oct 15, 2024
64c7635
clean up for merge
joyxyz1994 Oct 15, 2024
ad1f767
temporarily take out test
yalinli2 Oct 16, 2024
82c7de7
fix README figure dir
yalinli2 Oct 16, 2024
5ab2c35
release new version
yalinli2 Oct 16, 2024
422c33e
Merge branch 'main' of https://github.com/QSD-Group/EXPOsan into bsm2
yalinli2 Oct 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/build-dev.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: build-dev

on:
push:
branches: [ bsm2 ]
pull_request:
branches: [ bsm2 ]

jobs:
build:

runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10"]

steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install pytest
pip install --no-cache-dir git+https://github.com/BioSTEAMDevelopmentGroup/thermosteam.git@qsdsan
pip install --no-cache-dir git+https://github.com/BioSTEAMDevelopmentGroup/biosteam.git@qsdsan
pip install --no-cache-dir git+https://github.com/QSD-Group/QSDsan.git@dev
pip install --no-cache-dir -r requirements.txt
- name: Test with pytest
run: |
pytest
17 changes: 11 additions & 6 deletions exposan/bsm1/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,31 @@
from .system import *

_system_loaded = False
def load(reload=False, inf_kwargs={}, asm_kwargs={}, init_conds={}, aeration_processes=()):
def load(reload=False, suspended_growth_model='ASM1', reactor_model='CSTR',
inf_kwargs={}, asm_kwargs={}, settler_kwargs={},
init_conds={}, aeration_processes=()):
global _system_loaded
if not _system_loaded: reload = True
if reload:
global cmps, components, asm, sys
sys = create_system(
suspended_growth_model=suspended_growth_model,
reactor_model=reactor_model,
inf_kwargs=inf_kwargs,
asm_kwargs=asm_kwargs,
settler_kwargs=settler_kwargs,
init_conds=init_conds,
aeration_processes=aeration_processes,
)
O1 = sys.flowsheet.unit.O1
cmps = components = O1.components
asm = O1.suspended_growth_model
# O1 = sys.flowsheet.unit.O1
# cmps = components = O1.components
# asm = O1.suspended_growth_model
# Legacy names
global PE, SE, RE
global PE, SE#, RE
stream = sys.flowsheet.stream
PE = stream.wastewater
SE = stream.effluent
RE = stream.RWW
# RE = stream.RWW
dct = globals()
dct.update(sys.flowsheet.to_dict())
_system_loaded = True
Expand Down
Binary file modified exposan/bsm1/data/initial_conditions_asm2d.xlsx
Binary file not shown.
Binary file added exposan/bsm1/data/matlab_exported_data_asm2d.xlsx
Binary file not shown.
Loading
Loading