Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open a draft PR for discussion. Just added the layout and made sure the system can be created (using the most basic configuration in the report (and praying they have this implementation in MATLAB)
Note: you need to use the
metro
branch ofQSDsan
, although the unit operations need some cleanupDidn't dare to let it simulate at all, haven't looked at the parameter settings, etc. But first need to figure out:
HydraulicDelay
for now.Also not about BSM2 but BSM1 - does it make sense to run BSM1 using ASM2d? I made some changes in the
bsm1
module to allow this, but it might make no sense at all.And on
DiffusedAeration
, would be nice to storeDO_ID
so that when creating aerobic tanks, we can just get theDO_ID
from the process.