Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BSM2 layout #42

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Add BSM2 layout #42

merged 8 commits into from
Oct 18, 2023

Conversation

yalinli2
Copy link
Member

@yalinli2 yalinli2 commented Oct 15, 2023

Open a draft PR for discussion. Just added the layout and made sure the system can be created (using the most basic configuration in the report (and praying they have this implementation in MATLAB)
Figure 2023-10-15 191045

Note: you need to use the metro branch of QSDsan, although the unit operations need some cleanup

Didn't dare to let it simulate at all, haven't looked at the parameter settings, etc. But first need to figure out:

  1. Can I pretty much just copy the entire bsm1 layout into bsm2?
  2. There's a storage tank in the config that we don't have, using HydraulicDelay for now.

Also not about BSM2 but BSM1 - does it make sense to run BSM1 using ASM2d? I made some changes in the bsm1 module to allow this, but it might make no sense at all.

And on DiffusedAeration, would be nice to store DO_ID so that when creating aerobic tanks, we can just get the DO_ID from the process.

@yalinli2
Copy link
Member Author

  1. Where is influent TSS used?

@yalinli2 yalinli2 merged commit 4cc6f07 into main Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant