Adjust one body Jastrow SoA algorithm #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
+1 I am in favor of having one less fragile state machine in the code. I think the only place where a state machine is required is the drivers, which are explicit state machines. Are there any more of these in the SoA code? |
|
A state flag across classes are very fragile and must be minimized. Yes, drivers should take responsibility. |
markdewing
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SoA J1 was written not using the memory pool while J2 and JeeI do.
When a walker with its memory pool loaded, Det and J2 JeeI have the up-to-date value but J1 doesn't.
This is not a problem after all the electrons are proposed to move once but not from the beginning.
This potential risk is secured by checking the ParticleSet.Ready4Measure flag.
However, the flag is delicate and needs a careful maintaining.
This PR changes the algorithm to be aligned as J2 and JeeI. No more need to recompute since it is loaded from the memory pool and the needed size is small, order Nelec.
The state flag ParticleSet.Ready4Measure is also removed.
This PR also fixed the missing names of ParticleSet objects in Sandbox apps.