Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Rename ENABLE_HIP to BUILD_AFQMC_HIP #5261

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jan 1, 2025

Proposed changes

ENABLE_HIP was introduced by AFQMC for non-CUDA HIP-explicit source code.
In the current setting, ENABLE_ROCM is the switch to enable hip compilers and rocm libraries.
Thus, rename ENABLE_HIP to BUILD_AFQMC_HIP to reduce confusion.
Note that unfortunately, the current code cannot compile with this option on.

What type(s) of changes does this code introduce?

  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo ye-luo changed the title Rename ENABLE_HIP to BUILD_AFQMC_HIP. [CMake] Rename ENABLE_HIP to BUILD_AFQMC_HIP Jan 1, 2025
@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 1, 2025

Test this please

@prckent
Copy link
Contributor

prckent commented Jan 2, 2025

Obligatory and unsurprising questions and comments: any idea when this last worked? What is broken? Does it look easy to repair? This option unfortunately did not make it to the documentation or any test configuration.

I agree with the renaming.

@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 2, 2025

Obligatory and unsurprising questions and comments: any idea when this last worked? What is broken? Does it look easy to repair? This option unfortunately did not make it to the documentation or any test configuration.

I agree with the renaming.

Probably 4 years ago, beginning of 2021.
Any breakage caused by QMCPACK source code change over the years should be easily fixed.
Any breakage due to ROCm changes won't be easy to addressed.

@ye-luo
Copy link
Contributor Author

ye-luo commented Jan 3, 2025

Test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants